chore: register `createRuleTesterWithTypes` as a rule tester constructor by zaewc · Pull Request #12742 · typescript-eslint/typescript-eslint · GitHub
Skip to content

chore: register createRuleTesterWithTypes as a rule tester constructor - #12742

Merged
StyleShit merged 4 commits into
typescript-eslint:mainfrom
zaewc:fix/12628
Aug 23, 2026
Merged

chore: register createRuleTesterWithTypes as a rule tester constructor#12742
StyleShit merged 4 commits into
typescript-eslint:mainfrom
zaewc:fix/12628

Conversation

@zaewc

@zaewc zaewc commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

eslint-plugin-eslint-plugin only recognizes new RuleTester(), so every rule that goes through getTestInfo() was silently doing nothing in the test files that build their tester with createRuleTesterWithTypes()

7.6.2 added the ruleTesterConstructors setting, so all this does is register our factory there

That brings back 2595 require-test-error-positions errors in 54 files that were being skipped. As agreed, they're suppressed here rather than fixed, so this stays reviewable

One thing to note: 7.6.2 is only a few days old, so it needs a minimumReleaseAgeExclude entry for now. It can be dropped once the release passes our 7 day minimumReleaseAge

@typescript-eslint

typescript-eslint Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 09c7ff4
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6a8abfe1c497190008020241
😎 Deploy Preview https://deploy-preview-12742--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Aug 20, 2026
@nx-cloud

nx-cloud Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 09c7ff4

Command Status Duration Result
nx test typescript-estree --coverage=false ✅ Succeeded 11s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test ast-spec -u ✅ Succeeded 13s View ↗
nx run integration-tests:test ✅ Succeeded 1m View ↗
nx run ast-spec:clean-fixtures ✅ Succeeded <1s View ↗
nx run-many -t lint --projects=eslint-plugin --... ✅ Succeeded 58s View ↗
nx run-many -t lint --projects=typescript-estre... ✅ Succeeded 53s View ↗
Additional runs (42) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-08-23 09:45:40 UTC

@codecov

codecov Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (5c12e98) to head (09c7ff4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12742   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files         522      522           
  Lines       16932    16932           
  Branches     5257     5257           
=======================================
  Hits        15320    15320           
+ Misses        985      960   -25     
- Partials      627      652   +25
Flag Coverage Δ
unittest 90.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StyleShit
StyleShit requested changes Aug 23, 2026
View reviewed changes
Comment thread pnpm-workspace.yaml Outdated
StyleShit
StyleShit approved these changes Aug 23, 2026
View reviewed changes

@StyleShit StyleShit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions Bot added awaiting response Issues waiting for a reply from the OP or another party 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Aug 23, 2026
@StyleShit StyleShit removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 23, 2026
@StyleShit
StyleShit enabled auto-merge (squash) August 23, 2026 09:40
@StyleShit
StyleShit merged commit 5bbf21b into typescript-eslint:main Aug 23, 2026
63 checks passed
@nayounsang nayounsang mentioned this pull request Aug 27, 2026
Closed
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StyleShit StyleShit StyleShit approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge repo maintenance things to do with maintenance of the repo, and not with code/docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: replace createRuleTesterWithTypes with a method that returns RuleTesterConfig instead of RuleTester

2 participants

@zaewc @StyleShit