iframe-proxy

dikshit-n · 2026-09-06T06:39:56Z

Summary

Fixes #11616 — VirtualColumn throws error when used in WHERE conditions.

When a @VirtualColumn is used in a WHERE clause with createQueryBuilder object-style conditions, TypeORM incorrectly tries to reference the virtual property name as a literal database column, which does not exist.

Changes

File: src/query-builder/QueryBuilder.ts

getPredicates(): Now detects virtual columns and expands the query expression in WHERE conditions instead of using the non-existent column path.
buildConditionForVirtualColumn() (new): Builds SQL WHERE conditions for virtual columns by wrapping the computed query expression in appropriate operator syntax. Handles Equal, MoreThan, LessThan, Like, In, Not, And, Or, and other operators.
buildOperatorConditionForVirtualColumn() (new): Handles FindOperator types specifically for virtual column conditions.
getWhereCondition(): Routes virtual column predicates to the new handler.

File: test/functional/columns/virtual-columns/virtual-columns.test.ts

Added test: should expand virtual column in WHERE clause with QueryBuilder object-style condition

Example

Before (broken — causes Unknown column 'user.fullName' in 'where clause'):

WHERE `user`.`fullName` = 'John Doe'

After (fixed):

WHERE (CONCAT(`user`.firstName, ' ', `user`.lastName)) = 'John Doe'

Testing

TypeScript compiles cleanly with pnpm typecheck. The new test verifies that the WHERE clause uses the expanded query expression.

Closes #11616

github-actions · 2026-09-06T06:40:09Z

qodo-free-for-open-source-projects · 2026-09-06T06:42:11Z

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (1) 📎 Requirement gaps (2) 📜 Skill insights (0)

1. Raw parameters remain unregistered 📎 Requirement gap ≡ Correctness

Description

The virtual-column path invokes parameterized Raw SQL callbacks without registering their
objectLiteralParameters, leaving placeholders such as :value unresolved and potentially causing
execution to fail. As a result, object-style parameterized raw predicates that work on physical
columns fail on virtual columns.

Code

src/query-builder/QueryBuilder.ts[R1689-1690]

+        if (parameterValue.type === "raw" && parameterValue.getSql) {
+            return parameterValue.getSql(queryExpression)

Evidence
Compliance rule 5 requires virtual-column WHERE expressions to execute successfully. `Raw(callback,
parameters) stores named parameters on the FindOperator`, and the existing predicate path at
src/query-builder/QueryBuilder.ts[1570-1573] registers them with setParameters; in contrast, the
new virtual-column branch immediately returns getSql(queryExpression) without performing that
registration, leaving callback placeholders unbound.
Expand VirtualColumn expressions in QueryBuilder WHERE clauses
src/query-builder/QueryBuilder.ts[1689-1690]
src/query-builder/QueryBuilder.ts[1570-1573]
src/find-options/operator/Raw.ts[36-56]
src/find-options/FindOperator.ts[112-119]
src/query-builder/QueryBuilder.ts[1568-1576]
src/query-builder/QueryBuilder.ts[1685-1691]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Parameterized `Raw` operators on virtual columns return generated SQL before their `objectLiteralParameters` are registered with the query builder, leaving named placeholders unresolved.

## Issue Context
The standard `getWherePredicateCondition()` path calls `setParameters()` for `objectLiteralParameters` before processing the operator. Preserve that behavior when substituting the virtual-column query expression for the physical alias path, including when operators are nested.

## Fix Focus Areas
- src/query-builder/QueryBuilder.ts[1685-1691]
- src/query-builder/QueryBuilder.ts[1734-1756]
- src/query-builder/QueryBuilder.ts[1568-1588]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Raw(string) operator becomes unsupported 📎 Requirement gap ≡ Correctness

Description

For Raw("..."), the virtual-column handler falls through with operator type raw, which
createWhereConditionExpression() does not support and therefore throws a TypeError.
Virtual-column WHERE handling should preserve the established behavior of converting this valid
overload to an equality condition while expanding the virtual expression.

Code

src/query-builder/QueryBuilder.ts[R1759-1762]

+        return {
+            operator: parameterValue.type,
+            parameters: [queryExpression, this.createParameter(parameterValue.value)],
+        }

Evidence
Rule 5 requires object-style virtual-column WHERE conditions to work with their expanded
expressions. The string overload constructs a parameterless FindOperator of type raw without a
getSql callback, so the new virtual-column code does not handle it and passes raw to the SQL
condition renderer; because that renderer has no raw case, it throws for the unsupported operator,
whereas the existing non-virtual predicate path converts callback-less raw to equal using the
raw value.
Expand VirtualColumn expressions in QueryBuilder WHERE clauses
src/query-builder/QueryBuilder.ts[1759-1762]
src/find-options/operator/Raw.ts[45-47]
src/query-builder/QueryBuilder.ts[1590-1597]
src/find-options/operator/Raw.ts[41-56]
src/query-builder/QueryBuilder.ts[1685-1691]
src/query-builder/QueryBuilder.ts[1123-1190]
src/query-builder/QueryBuilder.ts[1590-1598]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description

Fix virtual-column predicates using `Raw(string)`, which currently fall through as an unsupported `raw` condition and crash during SQL rendering instead of becoming the established equality condition.

## Issue Context

`Raw(string)` creates a parameterless `FindOperator` of type `raw` without a `getSql` callback. Existing non-virtual handling converts this form into an `equal` condition using the raw value; virtual-column handling should match that behavior while using the expanded virtual-column expression.

## Fix Focus Areas

- src/query-builder/QueryBuilder.ts[1685-1691]
- src/query-builder/QueryBuilder.ts[1759-1762]
- src/query-builder/QueryBuilder.ts[1590-1598]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. Alias-qualified predicate test throws 🐞 Bug ≡ Correctness

Description

The added test passes company.totalEmployeesCount as a literal object key, but object-style
predicates expect an entity property path and do not strip the query alias.
findColumnsForPropertyPath therefore raises EntityPropertyNotFoundError before virtual-column
expansion is reached.

Code

test/functional/columns/virtual-columns/virtual-columns.test.ts[355]
+                .where({ "company.totalEmployeesCount": MoreThan(2) })

Evidence
createPropertyPath preserves the complete key, while findColumnsForPropertyPath searches entity
metadata for the resulting literal path and throws when no column matches. Thus
company.totalEmployeesCount cannot resolve to the totalEmployeesCount metadata column.
test/functional/columns/virtual-columns/virtual-columns.test.ts[350-356]
src/query-builder/QueryBuilder.ts[1416-1427]
src/query-builder/QueryBuilder.ts[1336-1397]
src/query-builder/QueryBuilder.ts[1506-1515]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new test uses an alias-qualified key that object-style QueryBuilder predicates cannot resolve, so it throws before testing virtual-column expansion.

## Issue Context
Object keys are converted verbatim to metadata property paths. The main query alias is not removed during metadata lookup.

## Fix Focus Areas
- test/functional/columns/virtual-columns/virtual-columns.test.ts[350-356]
- src/query-builder/QueryBuilder.ts[1409-1427]
- src/query-builder/QueryBuilder.ts[1506-1515]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

View action required (1)

4. Null predicates become unrestricted 🐞 Bug ≡ Correctness

Description

A null or undefined virtual-column value now causes the predicate to be omitted entirely, so a query
constrained only by that value returns unrestricted rows. The corresponding physical-column path
retains an equality predicate rather than silently removing the filter.

Code

src/query-builder/QueryBuilder.ts[R1667-1669]

+        if (parameterValue === null || parameterValue === undefined) {
+            return undefined
+        }

Evidence
The helper explicitly returns undefined for nullish values, and its caller only pushes a condition
when a value is returned. An empty condition list renders as an always-true expression, whereas the
existing non-operator path creates an equality parameter.
src/query-builder/QueryBuilder.ts[1663-1681]
src/query-builder/QueryBuilder.ts[1820-1827]
src/query-builder/QueryBuilder.ts[1648-1653]
src/query-builder/QueryBuilder.ts[1105-1118]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Direct QueryBuilder object conditions silently discard nullish virtual-column predicates, potentially broadening a constrained query to all rows.

## Issue Context
Null and undefined handling should remain consistent with other columns and the configured invalid-value behavior; it must not be hard-coded specifically for virtual columns.

## Fix Focus Areas
- src/query-builder/QueryBuilder.ts[1663-1681]
- src/query-builder/QueryBuilder.ts[1820-1827]
- src/query-builder/QueryBuilder.ts[1648-1653]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

5. Operator logic adds type noise 📘 Rule violation ⚙ Maintainability

Description

The new and/or implementation performs an unreachable undefined check and then uses `as
string[] to force the resulting type. This is inconsistent with the existing typed FindOperator`
implementation and violates the requirement to avoid defensive AI-style noise and type-bypassing
casts.

Code

src/query-builder/QueryBuilder.ts[R1724-1727]

+                    if (subCondition === undefined) return undefined
+                    return this.createWhereConditionExpression(subCondition)
+                })
+                .filter((c) => c !== undefined) as string[]

Evidence

Rule 4 prohibits abnormal defensive checks and casts that bypass type issues. The method's return
type is non-optional, but the added code checks that return for undefined, filters it again, and
asserts as string[]; the neighboring established implementation maps typed FindOperator<any>[]
directly without these constructs.

Rule 4: Remove AI-generated noise
src/query-builder/QueryBuilder.ts[1724-1727]
src/query-builder/QueryBuilder.ts[1614-1627]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The virtual-column operator implementation includes an unreachable defensive branch and a cast used to silence its inferred type.

## Issue Context
`buildOperatorConditionForVirtualColumn()` is declared to always return `WhereClauseCondition`, so `subCondition` cannot be `undefined`. Prefer the same typed mapping pattern used by the existing `and` and `or` paths.

## Fix Focus Areas
- src/query-builder/QueryBuilder.ts[1716-1727]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Author self-review: I have reviewed the code review findings, and addressed the relevant ones.

Context sources

✅ Tickets: 🎫 VirtualColumn throws error when used in WHERE conditions

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

dikshit-n added 2 commits September 6, 2026 12:09

fix: expand virtual column query in WHERE clause conditions

b83281e

fix: expand virtual column query in WHERE clause conditions

09d3f77

github-actions Bot added the linked-issue PR references an issue label Sep 6, 2026

github-actions Bot added the possible-duplicate PR may duplicate an existing open PR label Sep 6, 2026

qodo-free-for-open-source-projects Bot added the Compliance violation label Sep 6, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

fix: expand virtual column query in WHERE clause conditions - #12844

fix: expand virtual column query in WHERE clause conditions#12844
dikshit-n wants to merge 2 commits into
typeorm:masterfrom
dikshit-n:fix/virtual-column-where-clause

dikshit-n commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Sep 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

dikshit-n commented Sep 6, 2026

Summary

Changes

Example

Testing

Uh oh!

github-actions Bot commented Sep 6, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Sep 6, 2026

Code Review by Qodo

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant