{{ message }}
Docs: navbar menu buttons, menu JS toggle, delegated tooltips#42552
Open
mdo wants to merge 3 commits into
Open
Docs: navbar menu buttons, menu JS toggle, delegated tooltips#42552mdo wants to merge 3 commits into
mdo wants to merge 3 commits into
Conversation
A menu toggle is a button, not a link. Replace the navbar dropdown toggles' `<a href="#" role="button">` with semantic `<button>` (.nav-link already resets button styling). Fixes #40995.
The Via JavaScript section only showed instantiation. Add an example using getOrCreateInstance().show()/hide()/toggle(). Fixes #37042.
Add an example initializing one Tooltip on a parent with the selector option to cover many (and dynamically-added) triggers. Fixes #41020.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small docs fixes, one per commit:
<button>— replace the navbar dropdown toggles'<a href="#" role="button" data-bs-toggle="menu">with semantic<button type="button">(.nav-linkalready resets button styling). Fixes a.dropdown-toggle should be button.dropdown-toggle #40995.getOrCreateInstance().show()/hide()/toggle(). Fixes Bootstrap 5.2 - How to toggle a dropdown using javascript? #37042.selectoroption to cover many (and dynamically-added) triggers. Fixes Provide proper documentation for using Tooltip with selector #41020.markdownlint + prettier pass on all three files.
🤖 Generated with Claude Code