{{ message }}
Menu/Popover: setContent show gate + forms-in-menu auto-close#42551
Open
mdo wants to merge 2 commits into
Open
Menu/Popover: setContent show gate + forms-in-menu auto-close#42551mdo wants to merge 2 commits into
mdo wants to merge 2 commits into
Conversation
show() gated on _isWithContent(), which read config title/content and ignored content supplied through setContent(). A popover whose content was set only via setContent() could therefore never be shown. Count setContent() content in the gate via a shared _hasNewContent() helper. Fixes #40525.
clearMenus only skipped auto-close for input/select/option/textarea/form tag names, so clicking a form's label/button/etc. inside a menu closed it — breaking the documented forms-in-menu example. Skip auto-close for any click inside a form contained in the menu. Fixes #41803.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two menu/popover logic fixes, one per commit:
setContent()—show()gates on_isWithContent(), which read the configured title/content and ignored content supplied throughsetContent(). A popover whose content was set only viasetContent()could never be shown. CountsetContent()content in the gate (shared_hasNewContent()helper). Fixes [Popover] Cannot show popover if its title or content was set dynamically #40525.clearMenusonly skipped auto-close forinput/select/option/textarea/formtag names, so clicking a form's<label>/button/etc. inside a menu closed it — breaking the documented forms-in-menu example. Skip auto-close for any click inside a form contained in the menu. Fixes Clicks within forms within dropdowns no longer ignored and close the dropdown #41803.Unit tests added for both (each verified to fail without its fix); full suite passes; lint clean.
🤖 Generated with Claude Code