{{ message }}
Tooltip/Popover: fix prevented-show lockout and boolean title/content#42548
Open
mdo wants to merge 2 commits into
Open
Tooltip/Popover: fix prevented-show lockout and boolean title/content#42548mdo wants to merge 2 commits into
mdo wants to merge 2 commits into
Conversation
A prevented (or not-in-DOM) show() returned early without clearing _isHovered, leaving it stuck true. For click-triggered tips that made every later click hit the _enter() early-return, so the tip never reopened after one preventDefault(). Reset _isHovered on the early return. Fixes #39861.
data-bs-title="true" / data-bs-content="false" are auto-converted to booleans by the data-API, which failed the (null|string|element|function) type check and threw. Extend the existing number-to-string coercion in _configAfterMerge to booleans. Fixes #41925.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small tooltip/popover correctness fixes, one per commit:
show()returned early without clearing_isHovered, leaving it stucktrue. For click-triggered tips that made every later click hit the_enter()early-return, so the tip never reopened after onepreventDefault(). Fixes Popover event.preventDefault() for show.bs.popover: disables popover #39861.data-bs-title="true"/data-bs-content="false"are auto-converted to booleans by the data-API, which failed the(null|string|element|function)type check and threw. Extends the existing number→string coercion in_configAfterMergeto booleans. Fixes [Popover] data-bs-content="true"/"false" auto-converted to boolean causes TypeError, but "true"/"false" are valid string content. #41925.Unit tests added for both; full suite passes.
🤖 Generated with Claude Code