{{ message }}
fix TcpDecoder memory leak#54
Merged
Merged
Conversation
Contributor
Author
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=====================================================
+ Coverage 69.27388% 69.34263% +0.06874%
- Complexity 4108 4111 +3
=====================================================
Files 428 428
Lines 16774 16779 +5
Branches 1698 1700 +2
=====================================================
+ Hits 11620 11635 +15
+ Misses 4048 4039 -9
+ Partials 1106 1105 -1
|
Contributor
Author
|
@wardseptember PTAL |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
感谢贡献,我们评估一下 |
Collaborator
你需要用github账户提交push分支,然后才能授权成功 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

reproduce code
when TcpDecoder#decode() throw exception . ByteBuf param not released
expect refcnt 0 , actual 1
Solution
when decode excpetion . skip all readable bytes let
ByteToMessageDecoderrelease ByteBuf