Creates a MongoDBSource by JeffNeff · Pull Request #1402 · triggermesh/triggermesh · GitHub
Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Creates a MongoDBSource#1402

Merged
JeffNeff merged 20 commits into
mainfrom
mongodbsource
May 16, 2023
Merged

Creates a MongoDBSource#1402
JeffNeff merged 20 commits into
mainfrom
mongodbsource

Conversation

@JeffNeff

@JeffNeff JeffNeff commented May 1, 2023

Copy link
Copy Markdown
Contributor

By utilizing the MongoDB ChangeStreams (https://www.mongodb.com/docs/manual/changeStreams/) we are able to capture change events and emit them as Cloudevents.

@JeffNeff JeffNeff self-assigned this May 1, 2023
@JeffNeff JeffNeff marked this pull request as ready for review May 1, 2023 17:22
@sameersbn

sameersbn commented May 4, 2023

Copy link
Copy Markdown
Contributor

@FranBarrera FranBarrera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

Also this source should have a yaml sample in the sample folder.

Comment thread bin/golangci-lint Outdated
Comment thread cmd/triggermesh-controller/main.go Outdated
Comment thread config/500-controller.yaml Outdated
Comment thread pkg/sources/adapter/mongodbsource/adapter.go Outdated

@tzununbekov tzununbekov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick, the rest is looking good. Please squash before merging.

Comment thread pkg/sources/adapter/mongodbsource/adapter.go Outdated
Co-authored-by: Timur Zununbekov <t.zununbekov@gmail.com>
@JeffNeff JeffNeff requested a review from FranBarrera May 16, 2023 03:42
@JeffNeff JeffNeff merged commit b79f62a into main May 16, 2023
@JeffNeff JeffNeff deleted the mongodbsource branch May 16, 2023 03:42
@tzununbekov

Copy link
Copy Markdown
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants