{{ message }}
fix(rust): change ts_set_allocator to accept one optional Allocator object rather than 4 separate optional function pointers.#5657
Open
WillLillis wants to merge 1 commit into
Conversation
object rather than 4 separate optional function pointers. Helps prevent misuse via mixing different allocators. Also update the doc comment with relevant safety information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the API change, this PR also adds some safety documentation to
ts_set_allocator, indicating which invariants must be upheld. Finally, instead of caching the currently setfreefunction in a static global, we can just resolve whatts_current_freeis at use time. This should give more intuitive behavior (rather than silently using the libcfreefunction.AI Policy
Used Claude Opus 4.7 to look for additional safety pitfalls after an initial scan myself. This was particularly helpful for the alignment issue.
tree_sitter::set_allocatorin Rust SDK #5078