{{ message }}
VS2015 fixes for Tesselator.cpp#180
Merged
Merged
Conversation
Conda support for travis
C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(176): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(177): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(178): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(188): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(189): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(190): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(140): warning C4101: 'Umax': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(139): warning C4101: 'Umin': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(142): warning C4101: 'Vmax': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(141): warning C4101: 'Vmin': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(144): warning C4101: 'dUmax': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(145): warning C4101: 'dVmax': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(266): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(267): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(268): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(278): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(279): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(280): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(312): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(313): warning C4244: '=': conversion from 'Standard_Real' to 'float', possible loss of data [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(360): error C2039: 'max': is not a member of 'std' [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\sstream(12): note: see declaration of 'std' C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(360): error C3861: 'max': identifier not found [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(874): warning C4101: 'aUmaxLeft': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(875): warning C4101: 'aUmaxBottom': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(875): warning C4101: 'aVmaxBottom': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(874): warning C4101: 'aVmaxLeft': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(873): warning C4101: 'aUmaxBack': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj] C:\projects\pythonocc-core\src\Visualization\Tesselator.cpp(873): warning C4101: 'aVmaxBack': unreferenced local variable [C:\projects\pythonocc-core\cmake-build\_Visualization.vcxproj]
Contributor
Owner
Author
|
@jf--- Yes, why not. If ever you go with this, please add some get_edge_numpy() method, in order to keep old python methods that works fine. FreeCad guys implemented their own opengl backend, based on Coin3d I guess, that could be cool. |
tpaviot
added a commit
that referenced
this pull request
Jan 7, 2016
VS2015 fixes for Tesselator.cpp
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes following VS2015 c++ warnings/errors: