Install the image optimisation libraries in the base image by zerolab · Pull Request #461 · torchbox/torchbox.com · GitHub
Skip to content

Install the image optimisation libraries in the base image - #461

Merged
zerolab merged 1 commit into
mainfrom
chore/optimizers
Oct 22, 2026
Merged

zerolab merged 1 commit into
mainfrom
chore/optimizers

Conversation

@zerolab

@zerolab zerolab commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Description of Changes Made

Noticed that the image optimisation libraries were being installed only in the dev image, so they never made it to production

How to Test

Build local image, the different image optimisation libraries should be there and optimisation should kick in

Screenshots

N/A

Checklists

See checklists

PR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@zerolab zerolab added the enhancement New feature or request label Sep 17, 2026
@helenb

helenb commented Oct 12, 2026

Copy link
Copy Markdown
Member

@nickmoreton nickmoreton self-assigned this Oct 12, 2026
@zerolab

zerolab commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

I can haz merge and deploy @nickmoreton ?

@nickmoreton

Copy link
Copy Markdown
Collaborator

I can haz merge and deploy @nickmoreton ?

Sorry I didn't merge this. 🫤 I will bring it to Emily's attention for the next round or if we have some other work about to deploy.

@zerolab
zerolab merged commit f4bfe6d into main Oct 22, 2026
8 checks passed
@zerolab
zerolab deleted the chore/optimizers branch October 22, 2026 12:04
@zerolab

zerolab commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

Spoke with Helen. Merged to staging first, and merging to main to be deployed whenever

@helenb

helenb commented Oct 22, 2026

Copy link
Copy Markdown
Member

Spoke with Helen. Merged to staging first, and merging to main to be deployed whenever

It deploys straight away when you merge :) But all good.

@zerolab

zerolab commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants