Pec gh 146 by pecastro · Pull Request #150 · topogram/topogram · GitHub
Skip to content
This repository was archived by the owner on Mar 1, 2021. It is now read-only.

Pec gh 146#150

Merged
clemsos merged 3 commits into
topogram:masterfrom
pecastro:pec-gh-146
Oct 7, 2017
Merged

Pec gh 146#150
clemsos merged 3 commits into
topogram:masterfrom
pecastro:pec-gh-146

Conversation

@pecastro

@pecastro pecastro commented Oct 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@clemsos

clemsos commented Oct 7, 2017

Copy link
Copy Markdown
Member

@clemsos

clemsos commented Oct 7, 2017

Copy link
Copy Markdown
Member

Sorry i messed up with git so ended up with a 2nd PR fot his issue #151 😭

@clemsos clemsos merged commit 323c99e into topogram:master Oct 7, 2017
@pecastro

pecastro commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

I think the store positions only makes sense in the preset layout. Right now the commit will make it store for any layout you're right. So perhaps we can contain it just to be active in the 'preset' one.
I think that further down the line it would be great to be able to store the generated automatic layouts but I don't see that as a priority now ...
I'll push a fix for this ...

@clemsos

clemsos commented Oct 7, 2017

Copy link
Copy Markdown
Member

OK. Currently positions are stored only when you move manually, not when you apply a layout. What I thought is to add a "save positions" button somewhere, so when you think the layout is fine you can store it once and for all.

One issue is multi-user. If one person is moving nodes on a graph, it will reflect on the other's screen (app is reactive). It can be annoying when 2 people are looking at the same graph and moving nodes around

@clemsos

clemsos commented Oct 26, 2017

Copy link
Copy Markdown
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants