{{ message }}
Repository navigation
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @tony - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+18
to
+26
| Returns | ||
| ------- | ||
| dict | ||
| A dictionary conforming to WorkspaceConfig structure. | ||
| """ | ||
| tmuxp_workspace: dict[str, t.Any] = {} | ||
| tmuxp_workspace: dict[str, t.Any] = {} # Will conform to WorkspaceConfig at the end |
There was a problem hiding this comment.
suggestion: Annotate tmuxp_workspace with WorkspaceConfig type
Since WorkspaceConfig is already imported under TYPE_CHECKING, use it to annotate tmuxp_workspace and update the function's return type for better type safety.
Suggested change
| Returns | |
| ------- | |
| dict | |
| A dictionary conforming to WorkspaceConfig structure. | |
| """ | |
| tmuxp_workspace: dict[str, t.Any] = {} | |
| tmuxp_workspace: dict[str, t.Any] = {} # Will conform to WorkspaceConfig at the end | |
| from tmuxp.types import WorkspaceConfig | |
| def import_tmuxinator(workspace_dict: dict[str, t.Any]) -> WorkspaceConfig: | |
| """Return tmuxp workspace from a `tmuxinator`_ yaml workspace. | |
| Returns | |
| ------- | |
| WorkspaceConfig | |
| A dictionary conforming to WorkspaceConfig structure. | |
| """ | |
| tmuxp_workspace: WorkspaceConfig = {} # Will conform to WorkspaceConfig at the end |
tony
force-pushed
the
workspace-typings
branch
2 times, most recently
from
June 7, 2025 12:44
7466b20 to
ea9a61f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
==========================================
+ Coverage 82.56% 82.74% +0.18%
==========================================
Files 31 31
Lines 2770 2811 +41
Branches 518 517 -1
==========================================
+ Hits 2287 2326 +39
- Misses 346 347 +1
- Partials 137 138 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add example typings for workspace imports by introducing detailed TypedDict schemas and updating importers to reference the new workspace configuration types
Enhancements: