chore: replace req.connection with req.socket by younes-io · Pull Request #328 · tinyhttp/tinyhttp · GitHub
Skip to content

chore: replace req.connection with req.socket - #328

Merged
v1rtl merged 2 commits into
tinyhttp:masterfrom
younes-io:master
Apr 8, 2022
Merged

v1rtl merged 2 commits into
tinyhttp:masterfrom
younes-io:master

Conversation

@younes-io

@younes-io younes-io commented Oct 23, 2021 •

Copy link
Copy Markdown
Contributor

closes #316

@aldy505

aldy505 commented Oct 23, 2021

Copy link
Copy Markdown
Member

Comment thread packages/app/src/request.ts Outdated
@younes-io
younes-io requested a review from aldy505 October 23, 2021 17:54
@aldy505

aldy505 commented Oct 23, 2021

Copy link
Copy Markdown
Member

cc @talentlessguy

@v1rtl
v1rtl self-requested a review October 23, 2021 17:57
@younes-io

Copy link
Copy Markdown
Contributor Author

I have just realized that there are no tests for HTTPS

@v1rtl

v1rtl commented Oct 23, 2021

Copy link
Copy Markdown
Member

@v1rtl v1rtl added enhancement New feature or request core Affects `@tinyhttp/app` - the tinyhttp core labels Nov 24, 2021
@v1rtl
v1rtl merged commit ede18d2 into tinyhttp:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Affects `@tinyhttp/app` - the tinyhttp core enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace req.connection with req.socket

3 participants