Check if the strings 'for' and 'while' in function by koddsson · Pull Request #146 · timoxley/functional-javascript-workshop · GitHub
Skip to content

Check if the strings 'for' and 'while' in function#146

Open
koddsson wants to merge 1 commit into
timoxley:masterfrom
koddsson:check-for-loops-in-async-loops
Open

Check if the strings 'for' and 'while' in function#146
koddsson wants to merge 1 commit into
timoxley:masterfrom
koddsson:check-for-loops-in-async-loops

Conversation

@koddsson

Copy link
Copy Markdown

Fixes #119 by checking the given function for the strings "while" or "for". It has the obvious drawback of failing if the mere string is present.

Not sure if this is the best solution but I thought at least it would get a dialog started on how to fix this issue.

@timoxley

timoxley commented Nov 15, 2016

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async Loops verify process maybe incorrect.

2 participants