{{ message }}
Switch to NXP PDM MICFIL Zephyr native driver on i.MX8MP#9824
Merged
Conversation
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
This pulls in NXP PDM MICFIL drivers changes from Zephyr: aaa119d757294 dts: xtensa: nxp_imx8m: Add PDM MICFIL node 715fbd1f81ced drivers: dai: Add initial support for NXP MICFIL PDM IP Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
force-pushed
the
enable_micfil
branch
from
dedfa62 to
e9a43a5
Compare
lgirdwood
reviewed
Feb 10, 2025
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
LGTM, I would just add a comment (to make it easier later on when we remove legacy)
Member
There was a problem hiding this comment.
Would be nice to have an inline comment here stating why this is needed.
Support PDM MICFIL interface with Zephyr native driver interface. SOF PDM MICFIL driver is no longer supported and it will be soon removed. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
With Zephyr native driver we use timer domain. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Enable PDM MICFIL dts node and config option. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
force-pushed
the
enable_micfil
branch
from
e9a43a5 to
e521c75
Compare
Collaborator
Author
|
Changes since v2:
|
lgirdwood
approved these changes
Feb 10, 2025
Collaborator
Author
|
@lgirdwood @lyakh care to look at intel tests failing? are they caused by the west.yml update? |
lgirdwood
approved these changes
Feb 12, 2025
Member
Results look as expected. @lyakh pls review. |
kv2019i
approved these changes
Feb 12, 2025
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last part of switching from SOF driver to Zephyr native drivers for NXP platforms. After this gets merged in we will do cleanup for SOF drivers and remove them.