{{ message }}
ipc4: Simplify ipc response sending memory allocations#9777
Merged
Conversation
softwarecki
requested review from
abonislawski,
jxstelter,
lyakh,
marcinszkudlinski,
serhiy-katsyuba-intel and
tmleman
softwarecki
requested review from
bardliao,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
lgirdwood
approved these changes
Jan 16, 2025
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Nice simplification @softwarecki !
serhiy-katsyuba-intel
approved these changes
Jan 16, 2025
lyakh
reviewed
Jan 16, 2025
Collaborator
There was a problem hiding this comment.
not particularly against this change, but just for clarity - this is just "cleaning up," right? Without it it would work just as well?
Collaborator
Author
There was a problem hiding this comment.
Yes, this is just cleaning, without this change everything should work. The code only checks the tx_size field.
kv2019i
approved these changes
Jan 16, 2025
tmleman
approved these changes
Jan 16, 2025
Member
|
@softwarecki can you take a look at CI, seeing lots of errors. Thanks ! |
Since only one IPC request from a host is serviced at a time, the response can be stored in an existing buffer. Remove the allocation of an additional buffer to hold the response. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The buffer containing the payload of the sent IPC message should always be placed in shared memory (non-cached). Remove the unnecessary is_shared field from the ipc_msg structure and the code responsible for performing cache memory operations. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
ipc-remove-alloc
branch
from
4399250 to
33e5dc0
Compare
This was referenced Jan 16, 2025
Collaborator
|
As per #9776 (comment) , I've understood this could be hit on existing MTL/LNL/ARL configurations, so marking to v2.12 milestone for now. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since only one IPC request from a host is serviced at a time, the response can be stored in an existing buffer. Remove the allocation of an additional buffer to hold the response.
The buffer containing the payload of the sent IPC message should always be placed in shared memory (non-cached). Remove the unnecessary
is_sharedfield from theipc_msgstructure and the code responsible for performing cache memory operations.