{{ message }}
README.md: update Discord channel instructions#9762
Merged
Conversation
DaveLak
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
kv2019i
requested changes
Jan 3, 2025
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @DaveLak for the patch! This seems more future proof to link to Zephyr documentation.
Can you fix the commit message style to match the project style? See warnings in https://github.com/thesofproject/sof/actions/runs/12594094785/job/35107352776?pr=9762 and some examples with "git log README.md".. E.g. title should be Linxu kernel style "README.md: replace invalid Discord link" and body kept within 75 chars per line. Otherwise looks good to go.
Collaborator
|
While at it, please fix the commit subject and message: the link is not "invalid". I just tried it again and it works perfectly fine... when you have already been invited. So, not "invalid" but "restricted access" |
Replace the direct #sof Discord channel link with a reference to the Zephyr project's documentation for accessing their server, where the channel is hosted. The previous link only worked for users already in the Zephyr Discord server, potentially confusing new visitors looking to join the channel. Pointing to Zephyr's community docs provides the necessary context and instructions for getting an invite to access the #sof channel. Since the channel is part of Zephyr’s Discord server, directing readers to their official documentation ensures the instructions remain accurate while sparing this project from duplicating details. Fixes GitHub issue thesofproject#7161. Signed-off-by: David Lakin <github@themoderndev.com>
DaveLak
changed the title
Contributor
Author
marc-hb
approved these changes
Jan 10, 2025
dbaluta
approved these changes
Jan 13, 2025
lgirdwood
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the direct #sof Discord channel link with a reference to the
Zephyr project's documentation for accessing their server, where the
channel is hosted.
The previous link only worked for users already in the Zephyr Discord
server, potentially confusing new visitors looking to join the channel.
Pointing to Zephyr's community docs provides the necessary context and
instructions for getting an invite to access the #sof channel.
Since the channel is part of Zephyr’s Discord server, directing readers
to their official documentation ensures the instructions remain accurate
while sparing this project from duplicating details.
Fixes GitHub issue #7161.