{{ message }}
app: intel_adsp_ace15_mtpm.conf: clean up board config file#9609
Merged
lgirdwood merged 1 commit intoOct 25, 2024
Merged
Conversation
Group the configuration options per theme and order entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
kv2019i
force-pushed
the
202410-mtl-board-config-cleanup
branch
from
bb039bf to
9996a21
Compare
lgirdwood
approved these changes
Oct 23, 2024
lyakh
approved these changes
Oct 24, 2024
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this! Haven't checked every single line of course (can be easily done automatically by sorting and diffing the two versions), but, assuming there are no changes, this is a welcome change!
abonislawski
approved these changes
Oct 24, 2024
tmleman
approved these changes
Oct 24, 2024
tmleman
left a comment
tmleman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing a great job. I wanted to do it myself and have it on my to-do list. When I thought about it earlier, I also thought that it would be a good idea to separate the configs coming from Zephyr from those that are purely SOF (but I'm not sure if that would be better).
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group the configuration options per theme and order entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain.
No functional change, just shuffling options around and adding comments. Probably easier to review the resulting file without any diffs:
https://github.com/thesofproject/sof/tree/9996a21a04f617ce1b4517167aa33b67b25533c2/app/boards/intel_adsp_ace15_mtpm.conf