{{ message }}
ipc4: base_fw: Enable scheduler info retrieval for secondary cores#9511
Merged
kv2019i merged 1 commit intoOct 1, 2024
Merged
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
tmleman
requested review from
abonislawski,
dnikodem,
marcinszkudlinski,
serhiy-katsyuba-intel,
softwarecki and
tobonex
tmleman
force-pushed
the
topic/upstream/pr/ipc4/corex/schedulers_info_get
branch
2 times, most recently
from
7eb60bf to
df38838
Compare
This commit addresses the limitation in the schedulers_info_get function where scheduler information could only be retrieved for the primary core. The updated implementation now validates the core_id against the number of configured cores (CONFIG_CORE_COUNT) and initiates an IPC process on the requested core if it is not the current core. Changes include: - Adding a check to ensure the core_id is within the valid range. - Calling ipc4_process_on_core to handle IPC processing on secondary cores. - Returning appropriate IPC4 error codes based on the result of ipc4_process_on_core. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
serhiy-katsyuba-intel
approved these changes
Sep 25, 2024
tobonex
approved these changes
Sep 25, 2024
lgirdwood
approved these changes
Sep 26, 2024
Member
Collaborator
base_fw.c has more locations of mixing up the two error code families. The commit in this PR fixes one such case - a pretty harmless one, 0 is the same as Line 441 in b70d2bf Line 397 in b70d2bf IPC4_SUCCESS and -EINVAL
|
Member
|
@tmleman do you need to make any updates here for IPC4 codes now that fix has merged ? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses the limitation in the schedulers_info_get function where scheduler information could only be retrieved for the primary core. The updated implementation now validates the core_id against the number of configured cores (CONFIG_CORE_COUNT) and initiates an IPC process on the requested core if it is not the current core.
Changes include: