{{ message }}
rimage: use platform extra flags when signing LLEXT modules#9509
Merged
Conversation
The user can configure west to pass additional arguments to rimage for signing, we need to use them when signing LLEXT modules too. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
approved these changes
Sep 24, 2024
abonislawski
left a comment
abonislawski
left a comment
Member
There was a problem hiding this comment.
It should work but will duplicate -k parameter
Before:
rimage -o drc.llext.ri -e -c rimage_config.toml -k otc_private_key_3k.pem -l -r drc.llext
After:
rimage -o drc.llext.ri -e -c rimage_config.toml -k otc_private_key_3k.pem -l -r -k otc_private_key_3k.pem -f 2.10.99 -b 1 drc.llext
Collaborator
Author
Member
|
No issues, it doesnt matter for rimage. |
lgirdwood
approved these changes
Sep 26, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user can configure west to pass additional arguments to rimage for signing, we need to use them when signing LLEXT modules too.