{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should sof-logger
-lsupport also be removed?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure that's a good idea. As far as I can tell there's still some AMD (?) platforms and
imx8musing XTOS. I don't have the toolchain right now to test butsmexshould still be included in those builds. AFAICT removing-lfrom the logger would break the only way of logging for those platforms (as you need the ldc file for it to work).CC: @marc-hb please do correct me if I'm wrong here. Haven't really used
sof-loggerin a while :(LE: just noticed #9421, sorry for any unnecessary recent tags/review requests :(