{{ message }}
Nocodec amplifier+hdmi-in via I2S#7770
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html
This is very frequent with code style checks. They're right only the vast majority of the time but not all the time. |
Contributor
Author
|
Hi Team, Please do help to review and merge. |
plbossart
requested changes
Jun 12, 2023
67ea204 to
7a4e89f
Compare
Contributor
Author
plbossart
requested changes
Jun 19, 2023
plbossart
left a comment
Member
There was a problem hiding this comment.
the mclk_in support is questionable at best. see comments below
Adding support for rt1308 ssp amplifier and HDMI-in capture via I2S. Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
Adding support for the product which doesn't have no ssp amplifier but need to support HDMI audio playback and HDMI-in capture via I2S. Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
Adding support for the alderlake products which doesn't have no ssp amplifier but need to support HDMI audio playback and HDMI-in capture via I2S Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
plbossart
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.