fix: issue #889 by changing the annotated return type of `waiting_for` to `Self`. by eteran · Pull Request #890 · testcontainers/testcontainers-python · GitHub
Skip to content

fix: issue #889 by changing the annotated return type of waiting_for to Self.#890

Merged
alexanderankin merged 1 commit into
testcontainers:mainfrom
eteran:889-waiting-for-type-fix
Oct 2, 2025
Merged

fix: issue #889 by changing the annotated return type of waiting_for to Self.#890
alexanderankin merged 1 commit into
testcontainers:mainfrom
eteran:889-waiting-for-type-fix

Conversation

@eteran

@eteran eteran commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Fix issue #889 by changing the annotated return type of waiting_for to Self.

@alexanderankin alexanderankin changed the title Fix issue #889 by changing the annotated return type of waiting_for to Self. fix: issue #889 by changing the annotated return type of waiting_for to Self. Oct 2, 2025
@alexanderankin alexanderankin merged commit fe941b1 into testcontainers:main Oct 2, 2025
8 of 9 checks passed
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

alexanderankin pushed a commit that referenced this pull request Oct 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.13.2](testcontainers-v4.13.1...testcontainers-v4.13.2)
(2025-10-07)


### Bug Fixes

* **core:** Fix issues with doctests
([#893](#893))
([2e4d80a](2e4d80a))
* **core:** waiting improvements + remove decorators in core
([#894](#894))
([f93f379](f93f379))
* issue
[#889](#889)
by changing the annotated return type of `waiting_for` to `Self`.
([#890](#890))
([fe941b1](fe941b1))
* **mongo:** mongo start waiting forever for old mongo versions
([#783](#783))
([1388612](1388612))
* **redpanda:** copy the startup script to a path that can be written …
([#867](#867))
([e6b976d](e6b976d))
* **trino:** Remove deprecated class and decorator from Trino container
([#895](#895))
([bb646e9](bb646e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants