{{ message }}
Test documentation#511
Merged
Merged
Conversation
…nge are used to prevent updating requirements all the time.
zsdonghao
reviewed
Apr 19, 2018
Member
There was a problem hiding this comment.
should we keep the code reference here?
Member
Author
There was a problem hiding this comment.
I have no opinion on this, not my code.
zsdonghao
reviewed
Apr 19, 2018
| modules/activation | ||
| modules/models | ||
| modules/distributed | ||
| modules/db |
Member
Author
There was a problem hiding this comment.
I didn't found how to deactivate Sphinx from trying to build it. I had an error, maybe there is a way ;)
Member
There was a problem hiding this comment.
We are currently refactoring the DB module.To avoid this error, a possible way is to keep the DB doc and highlight this module is under construction.
Member
Author
There was a problem hiding this comment.
It was actually very nicely done. We can hardly make it any clearer
DEKHTIARJonathan
force-pushed
the
test_documentation
branch
from
b42fc09 to
37e86d1
Compare
DEKHTIARJonathan
force-pushed
the
test_documentation
branch
from
37e86d1 to
27524ae
Compare
added 3 commits
April 21, 2018 02:51
# Conflicts: # example/tutorial_binarynet_cifar10_tfrecord.py # example/tutorial_cifar10.py # example/tutorial_cifar10_tfrecord.py # example/tutorial_dorefanet_cifar10_tfrecord.py # example/tutorial_generate_text.py # example/tutorial_mnist.py # example/tutorial_mnist_float16.py # example/tutorial_ptb_lstm.py # example/tutorial_ptb_lstm_state_is_tuple.py # example/tutorial_ternaryweight_cifar10_tfrecord.py # example/tutorial_vgg16.py # example/tutorial_vgg19.py
# Conflicts: # example/tutorial_binarynet_cifar10_tfrecord.py # example/tutorial_dorefanet_cifar10_tfrecord.py # example/tutorial_generate_text.py # example/tutorial_mnist.py # example/tutorial_mnist_float16.py # example/tutorial_ptb_lstm_state_is_tuple.py # example/tutorial_ternaryweight_cifar10_tfrecord.py
Member
Author
Merged
zsdonghao
approved these changes
Apr 21, 2018
luomai
pushed a commit
that referenced
this pull request
Nov 21, 2018
* Activation Cleaning Docstring Test * Requirements Pinned with range to insure tested versions are used. Range are used to prevent updating requirements all the time. * setup.cfg file added with PEP8 configuration * activation.py refactored * docstring fixed - ready for documentation unittest * Yapf correction for max_line_length: 120 * test yapf refactored * test documentation added * Missing requirement added: sphinx * Allow test on documentation to pass on warning * Fix travis dependencies install * Travis install script fixed * Travis install command fixed * Requirements conflict solved * Yapf Style modified and merged in file "setup.cfg" * Yapf Confiuguration Updated * Code Refactored with new YAPF formating style * Code Refactored with new YAPF formating style * Code Refactored with new YAPF formating style * shorten codes * Various Cleaning * Trailing Slashes removed * Test Recurrent Fixed * Line Width Fix * docs requirements updated * fix example docs style * Codacy Issue Fixed * Merge Errors fixed * YAPF Style Applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a unittest for the documentation.
Warning before merging
Wait for PR #510 and #509 to be merged upfront.