Add tests for TF_CUDNN_DETERMINISTIC by duncanriach · Pull Request #25796 · tensorflow/tensorflow · GitHub
Skip to content

Add tests for TF_CUDNN_DETERMINISTIC#25796

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
duncanriach:cudnn_deterministic_testing
Feb 23, 2019
Merged

Add tests for TF_CUDNN_DETERMINISTIC#25796
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
duncanriach:cudnn_deterministic_testing

Conversation

@duncanriach

@duncanriach duncanriach commented Feb 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Some of the tests for the environment variable TF_CUDNN_DETERMINISTIC, which was added in pull requests 24747 and 25269.

@alextp alextp added the kokoro:force-run Tests on submitted change label Feb 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 16, 2019
@rthadur rthadur self-assigned this Feb 19, 2019
@rthadur rthadur added the size:M CL Change Size: Medium label Feb 19, 2019
@rthadur rthadur requested review from alextp and jlebar and removed request for jlebar February 19, 2019 17:54
@jlebar

jlebar commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

@rthadur rthadur requested review from chsigg and removed request for alextp February 19, 2019 18:18
@chsigg chsigg added the ready to pull PR ready for merge process label Feb 21, 2019
chsigg
chsigg reviewed Feb 22, 2019
View reviewed changes

@chsigg chsigg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are FYI, I will address them myself when merging your PR. Thanks.

Comment thread tensorflow/python/kernel_tests/cudnn_determinism_test.py
Comment thread tensorflow/python/kernel_tests/cudnn_determinism_test.py
from __future__ import print_function

import os
from collections import namedtuple

@chsigg chsigg Feb 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import entire module and then do collections.namedtuple below.

@duncanriach duncanriach Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks for catching that.

Comment thread tensorflow/python/kernel_tests/cudnn_determinism_test.py

@chsigg chsigg Feb 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort alphabetically.

@duncanriach duncanriach Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks.

@tensorflow-copybara tensorflow-copybara merged commit 33d0415 into tensorflow:master Feb 23, 2019
tensorflow-copybara pushed a commit that referenced this pull request Feb 23, 2019
@tensorflower-gardener
Merge pull request #25796 from duncanriach-nvidia:cudnn_deterministic…
caf3f17 
…_testing

PiperOrigin-RevId: 235309152
@jlebar jlebar mentioned this pull request Mar 7, 2019
Merged
@duncanriach duncanriach mentioned this pull request Jun 11, 2019
Merged
@duncanriach duncanriach mentioned this pull request Aug 9, 2019
Merged
@duncanriach duncanriach mentioned this pull request Oct 8, 2019
Closed
@duncanriach duncanriach deleted the cudnn_deterministic_testing branch October 17, 2019 20:27
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
7ca8c36 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752613730
@copybara-service copybara-service Bot mentioned this pull request Apr 29, 2025
Closed
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
aaa1b77 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752613730
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
d0f5d93 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752613730
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
7dd3a3c 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752613730
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
73eaf8b 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752662575
@copybara-service copybara-service Bot mentioned this pull request Apr 29, 2025
Merged
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
637c4f4 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752662575
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
3420b57 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25796 from Tixxx:tixxx/add_nvshmem_backend 764dcf1a1ade4505b93ec7b2295218d162a53fb3
PiperOrigin-RevId: 752662575
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2025
@Tixxx @tensorflower-gardener
PR #25796: [NVIDIA GPU] Add nvshmem to collective backend config and …
9a4c9fa 
…detect config setting in buffer colorer

Imported from GitHub PR openxla/xla#25796

Split from this [pr](openxla/xla#21973)
2: Add nvshmem to collective backend config and detect config setting in buffer colorer
Copybara import of the project:

--
764dcf1a1ade4505b93ec7b2295218d162a53fb3 by TJ Xu <tjx@nvidia.com>:

Add nvshmem to collective backend config and detect config setting in
buffer colorer

Merging this change closes #25796

PiperOrigin-RevId: 752752327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chsigg chsigg chsigg approved these changes

Assignees

@rthadur rthadur

Labels

cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@duncanriach @jlebar @chsigg @alextp @googlebot @kokoro-team @tensorflow-copybara @rthadur