Fix variables that seem to not be modified to consts. by shahzadlone · Pull Request #25347 · tensorflow/tensorflow · GitHub
Skip to content

Fix variables that seem to not be modified to consts.#25347

Merged
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
shahzadlone:upstream_master
Feb 26, 2019
Merged

Fix variables that seem to not be modified to consts.#25347
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
shahzadlone:upstream_master

Conversation

@shahzadlone

Copy link
Copy Markdown
Contributor

Based on this when I pointed out this to be const but it was too late, it was merging soon: #25269 (comment)

Please guide me incase I can make this even better.

Comment thread tensorflow/stream_executor/cuda/cuda_dnn.cc Outdated
@rthadur rthadur self-assigned this Jan 31, 2019
@rthadur rthadur added awaiting review Pull request awaiting review and removed awaiting review Pull request awaiting review labels Feb 2, 2019
@Harshini-Gadige Harshini-Gadige added the size:M CL Change Size: Medium label Feb 8, 2019

@drpngx drpngx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for const!

@drpngx drpngx added awaiting testing (then merge) kokoro:force-run Tests on submitted change and removed awaiting review Pull request awaiting review labels Feb 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 8, 2019
@shahzadlone

Copy link
Copy Markdown
Contributor Author

@Harshini-Gadige Harshini-Gadige added ready to pull PR ready for merge process and removed awaiting testing (then merge) labels Feb 12, 2019
@tensorflow-copybara tensorflow-copybara merged commit 3a8557a into tensorflow:master Feb 26, 2019
tensorflow-copybara pushed a commit that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants