Adding extra linear to semantic hashing discretization bottleneck. by martiansideofthemoon · Pull Request #1578 · tensorflow/tensor2tensor · GitHub
Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Adding extra linear to semantic hashing discretization bottleneck.#1578

Merged
afrozenator merged 1 commit into
tensorflow:masterfrom
martiansideofthemoon:semhash_fix
Jun 7, 2019
Merged

Adding extra linear to semantic hashing discretization bottleneck.#1578
afrozenator merged 1 commit into
tensorflow:masterfrom
martiansideofthemoon:semhash_fix

Conversation

@martiansideofthemoon

@martiansideofthemoon martiansideofthemoon commented May 20, 2019

Copy link
Copy Markdown
Contributor

This fixes the semantic hashing bug mentioned here https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/models/research/transformer_vae.py#L870
@dustinvtran, @lukaszkaiser is this the correct way to fix this bug?

@googlebot

Copy link
Copy Markdown

@googlebot googlebot added the cla: no PR author has not signed CLA label May 20, 2019
@martiansideofthemoon

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels May 20, 2019
@afrozenator

Copy link
Copy Markdown
Contributor

Hey @martiansideofthemoon -- thanks so much for the fix, I'll merge this in shortly, but would it be easy to add a unit test too to check if the fix works?

@martiansideofthemoon

Copy link
Copy Markdown
Contributor Author

Hi @afrozenator, what kind of a unit test would be useful? Should I compare the shapes of the input / output?

@afrozenator

Copy link
Copy Markdown
Contributor

Thanks a lot again for doing this @martiansideofthemoon ! Merging this now.

@afrozenator afrozenator merged commit db02a3b into tensorflow:master Jun 7, 2019
@afrozenator

Copy link
Copy Markdown
Contributor

tensorflow-copybara pushed a commit that referenced this pull request Jun 7, 2019
PiperOrigin-RevId: 252137294
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants