{{ message }}
Repository navigation
Conversation
bergundy
approved these changes
Oct 19, 2026
yux0
added this pull request to stack #12634
October 20, 2026 17:07
5 tasks
yycptt
reviewed
Oct 20, 2026
Member
There was a problem hiding this comment.
we need to support RPC calls in standby validator right? I think that's the main purpose of the separate validator. If validation can be done just be checking component state then existing task Validate() method already covers it?
Contributor
Author
There was a problem hiding this comment.
I assume RPC calls for internal temporal? We can have a offline sync on this.
Member
There was a problem hiding this comment.
internal temporal
for the cases I am aware of yes, usually talk to a different execution. Main thing is we shouldn't keep the execution locked when the RPC is happening. I know for parent/child we hold the lock, but ideally we don't do that?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This change separates active and standby validation for CHASM side effect tasks.
Why?
Today, both active and standby paths called Validate, requiring one function to decide whether a task should execute on active and whether it is still pending on standby. These decisions can require different rules: an active validator may stop retrying after an attempt threshold, while standby should continue waiting for the active cluster’s progress to replicate.
How did you test it?