{{ message }}
Repository navigation
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit ea22cfd. Configure here.
There was a problem hiding this comment.
Dev dependency for openai-agents not updated to match
Medium Severity
The production optional dependency for openai-agents was bumped to >=0.17.1 (line 31), but the dev/test dependencies on lines 74–75 still specify >=0.14.0. The code now calls self._impl.shutdown(timeout) with a timeout parameter that likely only exists in the >=0.17.1 API. While the uv.lock file currently resolves to 0.17.2, the dev dependency constraint permits installing older incompatible versions, which would cause a TypeError at runtime.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ea22cfd. Configure here.
THardy98
approved these changes
May 15, 2026
yuandrew
merged commit May 15, 2026
2bce35c
into
temporalio:backport/poller-shutdown/1.26.1
54 of 59 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Pick up shutdown fix cherry-pick for v1.14.1 patch release, temporalio/sdk-rust#1256
Why?
bug fix
Checklist
Closes
How was this tested:
Note
Medium Risk
Touches worker shutdown sequencing in the Rust bridge and bumps third-party tracing dependencies; regressions could surface as shutdown hangs/errors or integration incompatibilities.
Overview
Ensures
WorkerRef.initiate_shutdownin the Rust bridge enters the Tokio runtime (enter_sync!) before triggering core shutdown, aligning shutdown calls with other synchronous bridge methods.Updates dependency constraints and lockfile: bumps the optional
openai-agentsextra to>=0.17.1(lock to0.17.2), adjusts the OpenAI Agents trace providershutdownsignature to accept an optionaltimeout, and tightens the devlangsmithupper bound to<0.7.34.Reviewed by Cursor Bugbot for commit ea22cfd. Bugbot is set up for automated code reviews on this repo. Configure here.