Fix Javadoc for RateLimitsConfigurationProperties by akelsch · Pull Request #2729 · temporalio/sdk-java · GitHub
Skip to content

Fix Javadoc for RateLimitsConfigurationProperties#2729

Merged
Quinn-With-Two-Ns merged 1 commit into
temporalio:masterfrom
akelsch:patch-1
Nov 28, 2025
Merged

Fix Javadoc for RateLimitsConfigurationProperties#2729
Quinn-With-Two-Ns merged 1 commit into
temporalio:masterfrom
akelsch:patch-1

Conversation

@akelsch

@akelsch akelsch commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

What was changed

RateLimitsConfigurationProperties Javadoc for maxWorkerActivitiesPerSecond was wrongly describing to call setMaxConcurrentActivityExecutionSize. Also switch order according to constructor.

Why?

Confusing docs even though code behaves differently (correctly)

Checklist

  1. Closes minor issue :)

  2. How was this tested:
    Docs only

  3. Any docs updates needed?
    Javadoc updated

@akelsch akelsch requested a review from a team as a code owner November 18, 2025 12:53
@CLAassistant

CLAassistant commented Nov 18, 2025

Copy link
Copy Markdown

@CLAassistant

Copy link
Copy Markdown

@Quinn-With-Two-Ns Quinn-With-Two-Ns enabled auto-merge (squash) November 26, 2025 17:26
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 6bb0fdf into temporalio:master Nov 28, 2025
14 of 15 checks passed
@cursor cursor Bot mentioned this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants