{{ message }}
Repository navigation
Conversation
lilydoar
force-pushed
the
lilydoar/healthy-heartbeat-activities
branch
from
October 20, 2026 19:23
e4b7a42 to
3d50d6b
Compare
lilydoar
changed the base branch from
main
to
lilydoar/nexus-signal-request-id
October 20, 2026 19:23
lilydoar
added this pull request to stack #520
October 20, 2026 19:23
throughput_stress only heartbeats in its retry scenario, where the first attempt deliberately times out. Nothing exercises activities that stay alive by heartbeating, so load runs cover the heartbeat failure path but not sustained successful heartbeats. healthy-heartbeat-activities adds that many remote activities to each internal iteration. Each heartbeats for healthy-heartbeat-duration with a healthy-heartbeat-timeout heartbeat timeout and a single attempt, so a heartbeat timeout fails the run. Off by default. Uses the Go worker's existing heartbeat activity, so no worker change is needed.
lilydoar
force-pushed
the
lilydoar/healthy-heartbeat-activities
branch
from
October 20, 2026 20:27
3d50d6b to
924ff73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
New
throughput_stressoptions add healthy heartbeating remote activities to each internal iteration:healthy-heartbeat-activitieshealthy-heartbeat-durationhealthy-heartbeat-timeoutEach activity uses the Go worker's existing
Heartbeataction with no failed attempts and a heartbeat interval of a quarter of the timeout. It has a single attempt, so a heartbeat timeout fails the workflow and the run.Why
The only heartbeats
throughput_stressproduces come from its retry scenario, where the first attempt deliberately times out. Load runs exercise the heartbeat failure path but not activities that stay alive by heartbeating, which is the path that has to keep working under load, faults and restarts.Details worth reviewing
Heartbeataction exists only in the Go worker, so the help text marks the option Go-only, like the other Go-only options.1 + duration / (0.8 × timeout)RPCs.TestThroughputStressHealthyHeartbeatKeepsActivityAliveruns an activity longer than its heartbeat timeout against a real worker; with heartbeating disabled it fails with a heartbeat timeout.