refactor: make php language injector play nice with phpdocs by xHeaven · Pull Request #44 · tempestphp/tempest-phpstorm-plugin · GitHub
Skip to content

refactor: make php language injector play nice with phpdocs - #44

Open
xHeaven wants to merge 4 commits into
mainfrom
refactor/lang-injector
Open

xHeaven wants to merge 4 commits into
mainfrom
refactor/lang-injector

Conversation

@xHeaven

@xHeaven xHeaven commented Nov 29, 2025 •

Copy link
Copy Markdown
Member

Closes #14.

@github-actions

github-actions Bot commented Nov 29, 2025 •

Copy link
Copy Markdown

@xHeaven

xHeaven commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

@xepozz Does this look fine?

@xepozz

xepozz commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator
image

Thanks @xHeaven. I've tried to perform such collecting, but nothing worked.
The way is simple:

  • Target to a File in Injector
  • Find XmlValue/etc manually with PsiTreeUtil
  • Inject as it is now

But PHP layer don't work in this way, all completion is broken.

I've pushed a minor refactoring, I'm ok to merge it.

@xepozz

xepozz commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator
image

The picture I attached to the previous post is related to the web types. Lets disable injections from the web types / symbols, they block our manual injection. Can you check?

@xepozz

xepozz commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator
image With enabled web types. It blocks autocompletion, inspections

@xHeaven

xHeaven commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined view variable

2 participants