fix(web): open feed issues in a new tab by Aryan9891 · Pull Request #44 · tem-ctrl/open-source-guru · GitHub
Skip to content

fix(web): open feed issues in a new tab - #44

Merged
tem-ctrl merged 1 commit into
tem-ctrl:mainfrom
Aryan9891:fix/open-issues-in-new-tab
Oct 19, 2026
Merged

tem-ctrl merged 1 commit into
tem-ctrl:mainfrom
Aryan9891:fix/open-issues-in-new-tab

Conversation

@Aryan9891

Copy link
Copy Markdown
Contributor

What & why

When viewing the dashboard feed, clicking an issue or repository link currently navigates away from Open Source Guru in the same tab. This causes contributors to lose their place and scroll position in their feed.

This PR adds target="_blank" and rel="noopener noreferrer" to external issue and repository links in FeedItem so they open in a new tab.

Closes #26

How to test

  1. Run pnpm dev and navigate to http://localhost:3000/dashboard
  2. Click on an issue title or repository name in the activity feed
  3. Confirm that the target GitHub page opens in a new browser tab without replacing the dashboard view
  4. Run unit tests: pnpm --filter @osg/web test

Checklist

  • Focused on one thing, and discussed in an issue first if it's large
  • Follows the coding standards, including related changes
  • Tests added or updated for behavior changes
  • pnpm lint && pnpm typecheck && pnpm test && pnpm build passes locally

Notes for reviewers

Added unit tests in apps/web/app/(home)/dashboard/_components/FeedItem.test.tsx verifying that both issue and repository anchor tags have target="_blank" and rel="noopener noreferrer", alongside tests for availability states and the timeAgo helper.

@Aryan9891
Aryan9891 requested a review from tem-ctrl as a code owner October 17, 2026 14:02

@tem-ctrl tem-ctrl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to approve this pull request and I am looking forward to you future contributions.

Please star the repo and create an account on https://open-source-guru.dev/sign-in for even more contributions.

Thank you! 🥳

@tem-ctrl
tem-ctrl merged commit c4967cc into tem-ctrl:main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: open issues in a new tab

2 participants