Add Preview Support for GHE endpoints by rickardl · Pull Request #239 · telia-oss/github-pr-resource · GitHub
Skip to content

Add Preview Support for GHE endpoints#239

Draft
rickardl wants to merge 2 commits into
masterfrom
add-preview-support-ghe
Draft

Add Preview Support for GHE endpoints#239
rickardl wants to merge 2 commits into
masterfrom
add-preview-support-ghe

Conversation

@rickardl

@rickardl rickardl commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

This PR has a draft proposal for enabling support for Drafts (shadow-cat-preview) and Checks for GitHub Enterprise endpoints, it's an attempt to resolve the issues outlined in #235

It implements this through a change in the http.Transport implementation by extending it with required headers.

  • application/vnd.github.antiope-preview+json
  • application/vnd.github.shadow-cat-preview+json
  • etc ...

It doesn't currently offer any easy method to add further additions for V3 or V4, but there should be an optional field perform, if desired, in that case through new options.

  • V4PreviewSchemas (list)
  • V3PreviewSchemas (list)

I would appreciate feedback on this behavior, before I make further development investments.

@rickardl rickardl requested a review from itsdalmo October 23, 2020 00:14
@jlamb1

jlamb1 commented Oct 27, 2020

Copy link
Copy Markdown

@krisiye

krisiye commented Nov 4, 2021

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants