{{ message }}
Repository navigation
fix: accept componentIds as an array; run on Node 24 - #1
Merged
Merged
Conversation
A dispatch whose client_payload.componentIds is an array (an API-created webhook, or a hand-rolled dispatch) crashed the router with "componentIds.split is not a function". The router now joins an array before the cross-scope relevance check; a string routes as before. Runs on node24, which removes the Node.js 20 deprecation notice from every run summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Router: accept
client_payload.componentIdsas an array as well as a comma-separated string.TypeError: componentIds.split is not a function. It happened live on teambit/acme-modular-store.Runtime:
node20→node24inaction.ymland in the esbuild target. Every run summary carried GitHub's Node.js 20 deprecation notice; it is gone.CI (new):
.github/workflows/ci.ymlruns on every PR and onmain. It installs bit, runsbit test, and verifies thatdist/index.jsis fresh and loads. The repository had no CI before.Validation
bit test: 75/75 pass, including two new router tests (an array that matches the scope; an empty array that fails open).node scripts/verify-bundle.mjs: the rebuiltdist/index.jsloads under Node ESM and routes.After merge
Move the
v1tag to the merge commit, so every repository onteambit/bit-git-sync@v1picks the fix up.