{{ message }}
Issue #506: task_isolation - rebase feature on the new branch, add unit tests, add Lazy wrapper#676
Open
olologin wants to merge 1 commit into
Open
Issue #506: task_isolation - rebase feature on the new branch, add unit tests, add Lazy wrapper#676olologin wants to merge 1 commit into
olologin wants to merge 1 commit into
Conversation
…, add unit tests, add Lazy wrapper
Contributor
Member
|
Thank you very much for this pull request - let me look into this and see how we can make it better! |
Author
|
Not sure about the implementation, but regarding API: This way user can implement some kind of cooperative mutex locking that does not block the calling thread and instead runs corun_until until mutex is available. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Solves #506
Of course I just show my changes, and I expect some improvements must be made to upstream this. Let me know if you see some area for improvement.
Also, I had to rebase these changes from last release branch, so maybe I missed something. But for our internal usage (which is mostly Lazy class) it works fine. We did not see significant slowdowns because of additional operations in scheduler yet.
Would be great to upstream this eventually.
Brief explanation of how this works: #506 (comment)