{{ message }}
Added for_each_index_nested ( do not merge yet )#329
Open
bradphelan wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
No we never updated this |
|
it seems this PR has never been reviewed while it contains useful improvement |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for #328
I've added in for_each_index_nested however I cannot get the the test case to work. Have a look at the test case in
unittests/algorithm.cpp
if I use just for_each_index then the test case passes. If I use the implementation of for_each_index_nested as you reviewed yesterday then there is an error. Would you please have a look at and see what the problem may be.