fix(packaging): gate taosk system install to enterprise Linux server#35222
fix(packaging): gate taosk system install to enterprise Linux server#35222
Conversation
- gate taosk exposure to Linux x86_64/amd64/aarch64/arm64 - align tar/rpm/deb/cmake install entrypoints with install.sh/remove.sh - remove stale taosk links even when a platform is unsupported
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces platform-specific support for the taosk tool across the installation and removal scripts. It adds a helper function, is_taosk_supported_platform, to restrict taosk operations to Linux systems on x86_64 and ARM64 architectures. The review feedback identifies redundant logic in install.sh and remove.sh, where taosk is explicitly handled despite already being included in the tools array for cluster installations, which could lead to double execution or potential errors if environment variables are unset.
There was a problem hiding this comment.
This explicit removal of ${taosk_name} is redundant when ${taosk_name} is already included in the tools array (which happens in setup_env for cluster installs on supported platforms). However, if the intent is to ensure cleanup of stale symlinks when switching from a cluster to an edge installation or across platforms, this is acceptable. Note that if bin_link_dir is empty, this command could be dangerous if run as root.
There was a problem hiding this comment.
Calling remove_tools_of "${taosk_name}" here is redundant for cluster installations on supported platforms, as ${taosk_name} is added to the tools array at line 197 and will be processed again in the loop at line 313. While not a bug, it results in double execution of the removal logic for this specific tool.
Summary
Validation
Notes