{{ message }}
Add tools and Debian packaging for parsing dlopen ELF notes#33
Merged
Conversation
keszybz
reviewed
May 7, 2024
keszybz
reviewed
May 7, 2024
Member
Member
Author
Merged into the first commit with Co-authored-by - also added CI, and added back a way to print a "soname priority" list, that I need for the Debian tool, behind a new option |
4d6ba70 to
850a114
Compare
Member
Author
|
I have no idea why it errors out in the CI, the string seems fine... also works locally, any idea? |
|
The bit in the output makes me think that the else path here try:
if not isinstance(note_desc, str):
text = note_desc.decode('utf-8').rstrip('\0')
else:
text = note_desc
print(text)
except UnicodeDecodeError as e:
raise ValueError(f'{filename}: Invalid UTF-8 in .note.dlopen n_desc') from eis taken, but when I copy the above JSON into Emacs, it has a trailing null byte, which gives me the same error
Yes, unfortunately strings in Python can have null bytes, so stripping that might be what's needed. |
750a828 to
226230b
Compare
Member
Author
keszybz
requested changes
May 9, 2024
Co-authored-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Spec and implementation at systemd/systemd#32234