{{ message }}
Repository navigation
[Rector] Add NoScopeFetchBeforeCheapGuardRule and NarrowReturnToUnionParamRule to rector set - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Move two performance-oriented Rector rules into the shared rector set, so every rector package picks them up:
ScopeFetcher::fetch()called right before a cheap guard that does not use the scope; the guard should run first so most nodes bail out before scope resolution.Both were living in
rector-src/utils. They depend only onPhpParser/PHPStanplusRector\PHPStan\ScopeFetcher, so they are reusable across all rector packages.Registered in
config/rector-rules.neon, tests undertests/Rules/Rector.