{{ message }}
Repository navigation
[Toolkit][Shadcn] Make the rich color toasts of Sonner opaque in dark mode - #4117
Merged
Merged
Conversation
… mode | Q | A | -------------- | --- | Bug fix? | yes | New feature? | no | Deprecations? | no | Documentation? | no | Issues | Fix symfony#4094 | License | MIT With `richColors`, a toast in dark mode uses `dark:bg-green-900/20` (and the same for red, amber and blue). The background is only 20% opaque, so stacked toasts and the page show through it, and the text is hard to read. The fix mixes the same tint into the page background with `color-mix()`, for example `dark:bg-[color-mix(in_oklab,var(--color-green-900)_20%,var(--background))]`. The toast is now opaque and looks the same over the page. A new test reads the background alpha of each rich toast in dark mode. The existing screenshots still match. | | Background alpha (dark mode) | | --- | --- | | Before | 51 / 255 | | After | 255 / 255 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
richColors, a toast in dark mode usesdark:bg-green-900/20(and the same for red, amber and blue). The background is only 20% opaque, so stacked toasts and the page show through it, and the text is hard to read.The fix mixes the same tint into the page background with
color-mix(), for exampledark:bg-[color-mix(in_oklab,var(--color-green-900)_20%,var(--background))]. The toast is now opaque and looks the same over the page.A new test reads the background alpha of each rich toast in dark mode. The existing screenshots still match.