{{ message }}
fix: Added missing getrandom wasm_js feature to surrealdb-types#7074
Open
emirror-de wants to merge 1 commit intosurrealdb:mainfrom
Open
fix: Added missing getrandom wasm_js feature to surrealdb-types#7074emirror-de wants to merge 1 commit intosurrealdb:mainfrom
emirror-de wants to merge 1 commit intosurrealdb:mainfrom
Conversation
github-actions
Bot
added
the
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation?
Compilation of
surrealdb-typesfails withwasm*-unknown-unknowntargets are not supported by default, which is a result ofgetrandomhavingwasm_jsfeature not enabled.What does this change do?
Added
getrandomto conditional dependency fortarget_family = "wasm"that enableswasm_jsfeature.What is your testing strategy?
Compiling
surrealdb-typestowasmtarget.Is this related to any issues?
surrealdbissuessurrealdb-protocolPR#32 to also be mergedDoes this change need documentation?
Does this change make any alterations to environment variables or CLI commands?
Have you read the Contributing Guidelines?