Repository navigation
fix(docs): stop WebKit splitting short code tokens in table cells - #52065
jbergstroem wants to merge 1 commit into
Conversation
Give cells that contain only a code token a minimum width so they stay intact while long values still wrap in Webkit/Safari.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
|
Thanks for contributing to Supabase! ❤️ Our team will review your PR. A few tips for a smoother review process:
|
github-actions
Bot
added
the
documentation
|
@jbergstroem is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the Safari/WebKit issue and the documentation table-cell fix. It is concise and directly related to the main change. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The pull request description includes the required Problem, Solution, Review instructions, and Checklist sections. It also provides before-and-after screenshots and preview links. The review procedure… |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Description check
-
Explanation
The pull request description includes the required Problem, Solution, Review instructions, and Checklist sections. It also provides before-and-after screenshots and preview links. The review procedure is clear, but it uses one bullet instead of a numbered procedure.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
| * a code token prevents that while long values still wrap. | ||
| */ | ||
| .prose table td:not(:first-child):has(> code:only-child) { | ||
| min-width: 5rem; |
There was a problem hiding this comment.
This is quite arbitrary since it will still happen if a string is larger than this width.
Isn't there another css property or hack that would fix it for any string length? 🤔
There was a problem hiding this comment.
I was messing around with different breaks but it then led to other sections becoming too wide / introducing a scrollbar. I believe @antlio was working on a refactor of the tables that might address this in a better way - happy to close in favor of that.
There was a problem hiding this comment.
yes will make sure to push something today then (will ping you there to ensure it works!)
3 participants
Problem
In Safari, short words break lines in our tables given how the break-all rule is applied.
Solution
Give cells that contain only a code token a minimum width so they stay intact while long values still wrap in Webkit/Safari.
Additional context
Before
After
Development preview
Review instructions
Checklist
Check all before review:
/write-the-docsor/edit-the-docsskill, which applies the docs style guide