fix(studio): push advisor to health checks by default by kemaldotearth · Pull Request #52064 · supabase/supabase · GitHub
Skip to content

fix(studio): push advisor to health checks by default - #52064

Open
kemaldotearth wants to merge 1 commit into
masterfrom
fix/first-item-advisors
Open

kemaldotearth wants to merge 1 commit into
masterfrom
fix/first-item-advisors

Conversation

@kemaldotearth

Copy link
Copy Markdown
Contributor

Problem

A small quirk since we launched health checks is that our Advisor top level menu was still going to security advisors by default. This mean't the second item on the sub menu is highlighted.

Solution

Defaults to first item on the list, health advisors.

Review instructions

  1. Open studio.
  2. Click the Advisors tab on the sidebar.

@kemaldotearth
kemaldotearth requested a review from a team as a code owner October 21, 2026 09:23
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: supabase/supabase/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b8df487-b9cc-4c09-b18a-6dbd7ad06b8c
📥 Commits

Reviewing files that changed from the base of the PR and between 3af897e and 68fe52c.

📒 Files selected for processing: 2
  • apps/studio/components/layouts/Navigation/NavigationBar/NavigationBar.utils.test.tsx
  • apps/studio/components/layouts/Navigation/NavigationBar/NavigationBar.utils.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The Advisors route now points to /advisors/health when the health advisor feature flag is enabled and /advisors/security otherwise. Building projects continue to use buildingUrl.

Changes: Advisor navigation

Layer / File(s) Summary
Flag-driven advisor route
apps/studio/components/layouts/Navigation/NavigationBar/NavigationBar.utils.tsx, apps/studio/components/layouts/Navigation/NavigationBar/NavigationBar.utils.test.tsx
OtherFeatures includes the optional health advisor setting. useGenerateOtherRoutes reads the healthAdvisor flag and passes it to generateOtherRoutes. Tests cover the default security route and the enabled health route.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: joshenlim

Merge Risk: ⚪ Minimal · up to 68fe5

The flag-driven advisor routing change is covered by tests for both route paths and presents no identified merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: routing the Advisors menu to Health Advisors by default.
Description check Passed The description includes the required Problem and Solution sections and provides clear review steps. The optional checklist is not completed, but the description is otherwise sufficiently complete.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants