{{ message }}
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Claude’s sole documentation nit is refuted: the comments remain accurate for bounded concurrency, and the stop timing change is documented. Static inspection found no additional actionable issues; tests were not run.
Findings
No issues found.
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/src/command-internal/docker-remove-all.ts:140(documentation): The function documentation and inline stop comment still imply that every container stops at once despite the new concurrency cap.
Refuted: Neither comment promises simultaneous starts or unbounded concurrency. The Effect.all call at lines 167–175 still stops every container concurrently, with a limit of eight. commands/stop/SIDE_EFFECTS.md:175–177 explicitly documents the cap and additional grace periods. The trusted root CLAUDE.md comment policy also discourages restating maintained documentation in comments.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 0 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
fixes
supabase startandsupabase stopfailing every few runs on podman machinewhats hurting the user?
on macOS with podman machine and no
dockeron PATH,supabase startfails every few runs withfailed to inspect docker imageandssh: handshake failed: EOFsupabase stopfails the same way withfailed to stop container: exit 125and leaves the stack behindboth fire one
podmancall per image or container all at once, and each call opens its own ssh session into the VM, whose sshd drops new ones once ten are still in the handshakenow fixed by?
capping those calls at 8 in flight so every handshake gets accepted, rather than retrying, which would only hide the drops and add delay
Note
docker shares the same cap, so stopping more than 8 containers that ignore their stop signal, so it can take an extra smol grace period...
visual rep:
flowchart LR subgraph before["before"] A["start / stop"] --> B["one podman call per image or container, all at once"] B --> C["sshd drops past ten handshakes"] C --> D["start / stop fail"] end subgraph now["now"] E["start / stop"] --> F["at most 8 podman calls in flight"] F --> G["all handshakes accepted"] endref:
startfailing on podman without snippets (CLI-2690) #7089