{{ message }}
Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Confirmed Claude’s single minor finding: encrypted client-key settings are silently omitted, while native execution can still inherit those settings from the shell. Codex reported no findings. Verification was static; no tests were run.
Findings
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
remote
db dumpand the firstdb pullseed now pass the resolved TLS settings topg_dumpwhats introduced?
pg_dumponly got host, port, user, password and database, so a container dump ignoredPGSSLMODE=verify-full, trusted any CA, and got turned away by servers that require a client cert.for the linked project and a remote
--db-url, it now gets the resolvedsslmodeand connect timeout, the root cert underrequireorverify-*, and the client cert unless the key needssslpasswordIn a container the cert files are mounted read only, and a missing one fails before docker runs
Note
a remote dump that only worked because verification was skipped now fails. local targets and runs without TLS or timeout settings are unchanged
visual rep:
flowchart TD conn["resolved connection"] --> remote{"remote target?"} remote -- no --> plain["host, port, user, password, database"] remote -- yes --> tls["+ sslmode and connect timeout<br/>+ root cert under require or verify-*<br/>+ system root cert forces verify-full<br/>+ client cert unless the key needs sslpassword"] tls --> where{"where pg_dump runs"} where -- container --> box["cert files checked, then mounted read only<br/>key copied to a private file<br/>verify-* without root cert, or system, uses the image CA bundle"] where -- native --> host["host paths kept<br/>verify-* without root cert uses ~/.postgresql/root.crt, else the host CA bundle<br/>system uses the host CA bundle"] plain --> dump["pg_dump"] box --> dump host --> dumpref
PGSSL*env ondb push --linked(CLI-2753) #7261