test(repo): retry stalled live updates and name stalled analytics polls by 7ttp · Pull Request #7041 · supabase/cli · GitHub
Skip to content

test(repo): retry stalled live updates and name stalled analytics polls - #7041

Merged
7ttp merged 5 commits into
developfrom
7ttp/feww-more-flakes
Oct 7, 2026
Merged

7ttp merged 5 commits into
developfrom
7ttp/feww-more-flakes

Conversation

@7ttp

@7ttp 7ttp commented Oct 7, 2026

Copy link
Copy Markdown
Member

TL;DR

retries the network restrictions live update once when the platform stalls it, and makes the analytics poll say what stalled

  • network-restrictions update failed with expected 1 to be +0 and no stderr. the platform's apply stalled until the harness killed the cli at the 60s exit guard. the update is now re-issued once when it was killed before printing its result, the same way the restore already retries, and a second stall fails naming the kill

  • the Logflare stored id poll in Owner.analytics ran out with a bare NoSuchElementError after Analytics left healthy mid test. it now fails with NotStoredError naming the first or sentinel event, its id and the poll count

ref

@7ttp 7ttp self-assigned this Oct 7, 2026
@7ttp
7ttp requested a review from a team as a code owner October 7, 2026 11:34

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed. Code inspection confirms Claude’s diagnostic nit: a failed update retry reports only the second attempt in the thrown error. Codex reported no findings. No blocking issues were identified.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/commands/network-restrictions/update/update.live.test.ts:173 diagnostics claude When the update stalls twice, the thrown error includes only the second attempt’s diagnostics. The first attempt appears only in a warning, whereas a twice-failed restore includes both attempts in its error.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

@7ttp
7ttp enabled auto-merge October 7, 2026 18:48
@7ttp
7ttp added this pull request to the merge queue Oct 7, 2026
Merged via the queue into develop with commit 0cc816f Oct 7, 2026
25 checks passed
@7ttp
7ttp deleted the 7ttp/feww-more-flakes branch October 7, 2026 18:57
TFSebben pushed a commit to TFSebben/supabase_cli that referenced this pull request Oct 23, 2026
## TL;DR

re-issues the live `branches create` once when the platform rejects it
because the database restarted mid-create

- `branches list` (and `branches create` on `main` / `next`) failed with
`unexpected create branch status 400: … FATAL: 57P01: terminating
connection due to administrator command` (also seen as `the database
system is shutting down`). the platform restarts the database it is
configuring while the create is in flight. the shared live helper now
recognises only that rejection, removes the half-made branch if it got
listed, and re-issues the create once, the same way supabase#7041 handles the
network restrictions stall. a second rejection still fails the test, and
`create.live.test.ts` uses the same helper

## ref

- spotted in: [branches
list](https://github.com/supabase/cli/actions/runs/39221185565/job/117956603829)

---
_Generated by [Claude
Code](https://claude.ai/code/session_016f5jekWaBDRtATpEf65mtq)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants