Small discrete adjoint tweaks and other fixes by pcarruscag · Pull Request #950 · su2code/SU2 · GitHub
Skip to content

Small discrete adjoint tweaks and other fixes#950

Merged
talbring merged 11 commits into
developfrom
multiphysics_discadj_tweaks
Apr 29, 2020
Merged

Small discrete adjoint tweaks and other fixes#950
talbring merged 11 commits into
developfrom
multiphysics_discadj_tweaks

Conversation

@pcarruscag

@pcarruscag pcarruscag commented Apr 24, 2020

Copy link
Copy Markdown
Member

Proposed Changes

  • Fixes the adjoint residual computation for multizone cases (which was wrong on first inner iterations due to cross term extraction).
  • Fixes (hopefully for good) discadj FEA solutions when INCREMENTAL_LOAD=YES (left over from CFEASolver CMeshSolver maintenance #933)
  • Add relaxation to CDiscAdjSolver via option RELAXATION_FACTOR_ADJOINT, that replaces the old RELAXATION_FACTOR_ADJFLOW . I found this to be necessary for adjoint FSI problems, the adjoint of the interpolation matrix (and therefore the cross terms) are not smooth which makes convergence more difficult. In version 6 this was achievable via the old options RELAXATION_FACTOR_FLOW/TURB.
  • Adds OpenMP directives to the CFL adaptation routine (a "todo" from Hybrid Parallel Compressible RANS Solvers #861), restricts the Min/Max/Avg CFL calculation to the fine grid (which will change the output but not the solution).

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@economon economon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.. just a few comments

Comment thread SU2_CFD/include/solvers/CFEASolver.hpp
Comment thread SU2_CFD/src/solvers/CDiscAdjSolver.cpp Outdated
Comment thread SU2_CFD/src/solvers/CDiscAdjSolver.cpp Outdated
Comment thread SU2_CFD/src/solvers/CSolver.cpp

@talbring talbring left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments below ..

Comment thread TestCases/parallel_regression_AD.py
Comment thread SU2_CFD/src/solvers/CDiscAdjSolver.cpp Outdated

@talbring talbring left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcarruscag

@talbring talbring merged commit 53fb61f into develop Apr 29, 2020
@talbring talbring deleted the multiphysics_discadj_tweaks branch April 29, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants