Cleanup of NEMO files by WallyMaier · Pull Request #1923 · su2code/SU2 · GitHub
Skip to content

Cleanup of NEMO files#1923

Merged
WallyMaier merged 8 commits into
developfrom
nemo_updates
Feb 17, 2023
Merged

Cleanup of NEMO files#1923
WallyMaier merged 8 commits into
developfrom
nemo_updates

Conversation

@WallyMaier

@WallyMaier WallyMaier commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Proposed Changes

This is a chore PR to const variables when allowed and to alter loops to prevent declared iterators. This may be unnecessary/overkill.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pr-triage pr-triage Bot added the PR: draft label Feb 14, 2023

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

Comment thread SU2_CFD/src/solvers/CNEMONSSolver.cpp Fixed
@WallyMaier WallyMaier marked this pull request as ready for review February 15, 2023 17:48
@WallyMaier

Copy link
Copy Markdown
Contributor Author

@jtneedels

Copy link
Copy Markdown
Contributor

@jtneedels @pcarruscag Any idea why the regressions may be struggling?

It's just axi_viscone, so something must have been changed in the axisymmetric source residual.

@pcarruscag

Copy link
Copy Markdown
Member

Comment thread SU2_CFD/src/solvers/CNEMONSSolver.cpp Fixed

@jtneedels jtneedels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WallyMaier WallyMaier merged commit f33b248 into develop Feb 17, 2023
@WallyMaier WallyMaier deleted the nemo_updates branch February 17, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants