Write Z-Velocity and temperature only when solved by bigfooted · Pull Request #1920 · su2code/SU2 · GitHub
Skip to content

Write Z-Velocity and temperature only when solved#1920

Merged
bigfooted merged 7 commits into
developfrom
fix_3d_output
Feb 11, 2023
Merged

Write Z-Velocity and temperature only when solved#1920
bigfooted merged 7 commits into
developfrom
fix_3d_output

Conversation

@bigfooted

@bigfooted bigfooted commented Feb 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed Changes

Do not write Z-velocity or temperature when the (adjoint) equations are not solved.

Related Work

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pr-triage pr-triage Bot removed the PR: draft label Feb 10, 2023
@bigfooted bigfooted changed the title [WIP] Fix 3d and temperature output [WIP] Write Output Z-Velocity and temperature only when solved Feb 10, 2023
@bigfooted bigfooted changed the title [WIP] Write Output Z-Velocity and temperature only when solved [WIP] Write Z-Velocity and temperature only when solved Feb 10, 2023
@bigfooted bigfooted changed the title [WIP] Write Z-Velocity and temperature only when solved Write Z-Velocity and temperature only when solved Feb 10, 2023
WallyMaier
WallyMaier reviewed Feb 10, 2023
View reviewed changes
Comment thread TestCases/serial_regression_AD.py
pcarruscag
pcarruscag reviewed Feb 10, 2023
View reviewed changes
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
Comment thread SU2_CFD/src/output/CAdjFlowIncOutput.cpp Outdated
pcarruscag
pcarruscag reviewed Feb 10, 2023
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compressible output needs the same change

@bigfooted bigfooted merged commit 98507bc into develop Feb 11, 2023
@bigfooted bigfooted deleted the fix_3d_output branch February 11, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WallyMaier WallyMaier WallyMaier left review comments
@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:chore PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigfooted @WallyMaier @pcarruscag